Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update globby to v11.1.0 #483

Closed
Lehoczky opened this issue May 6, 2023 · 1 comment · Fixed by #581
Closed

Update globby to v11.1.0 #483

Lehoczky opened this issue May 6, 2023 · 1 comment · Fixed by #581

Comments

@Lehoczky
Copy link

Lehoczky commented May 6, 2023

Hi Tim,

I've recently run into an issue relating to the old globby version this package uses. I've cloned the repo, updated globby to v11.1.0 and every test is passing on my machine (win 10, node 16):

> mocha --recursive test



  gh-pages
    main
      ✔ --dist lib
      ✔ --dist lib -n
      ✔ --dist lib -f
      ✔ --dist lib -x
      ✔ --dist lib --dotfiles
      ✔ --dist lib --dest target
      ✔ --dist lib -a target
      ✔ --dist lib --git path/to/git
      ✔ --dist lib --user Full Name <[email protected]>
      ✔ --dist lib --user [email protected]
      ✔ --dist lib -u Full Name <[email protected]>
      ✔ --dist lib --before-add C:\Users\ifjle\Projects\gh-pages\test\bin\fixtures\beforeAdd.js
      ✔ --dist lib -u junk email (user error)

  basic usage
    ✔ pushes the contents of a directory to a gh-pages branch (1651ms)
    ✔ can push to a different branch (1729ms)

  the beforeAdd option
    ✔ runs a provided async function before adding files (1985ms)

  the dest option
    ✔ allows publishing to a subdirectory within a branch (1954ms)

  the src option
    ✔ can be used to limit which files are included (1860ms)

  the remove option
    ✔ removes matched files in remote branch (1703ms)
    ✔ skips removing files if there are no files to be removed (1434ms)

  index
    getCacheDir()
      ✔ works for [email protected]:<username>/<project>.git
      ✔ works for https://github.com/<username>/<project>.git
      ✔ works for https://<username>:<password>@github.com/<username>/<project>.git

  util
    byShortPath
      ✔ sorts an array of filepaths, shortest first
    uniqueDirs
      ✔ gets a list of unique directory paths
      ✔ gets a list of unique directories on absolute paths
    dirsToCreate
      ✔ gets a sorted list of directories to create
    getUser
      ✔ gets the locally configured user (309ms)


  28 passing (13s)

Would you accept a PR related to this change? Or is there a particular reason why gh-pages is using such an old globby version?

@dheitzer
Copy link

dheitzer commented Oct 8, 2024

Was there any consideration for accepting a PR for this?. Snyk is reporting gh-pages as vulnerable due to globby's use of inflight package:

[email protected][email protected][email protected][email protected]

It seems that later versions of globby/glob do not have this dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants