-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflicts with @types/eslint
due to eslint-formatter-pretty
dependency
#221
Comments
This would be wrong because it uses types from that package in prod. |
Where do you find it using types in Prod and how would that look like tbh I cannot imagine as types can only be used on the type level? Likely I haven't inspected what this package does. |
However, if this is the case, then likely it should be followed the recommendations for such scenarios. Which from my point of view is specifying it as a peer dep and with only a lower bound on the version, like also done here https://github.com/prettier/eslint-plugin-prettier/blob/51324d9cdf8b883e2a392904d0f73da9eca6a808/package.json#L52 As you are deeper in the project please let me know what you think @sindresorhus |
Due to the usage of
eslint-formatter-pretty
in version 4 I get some conflicts with newer versions of eslint plugins. Here withnpm ci
In the end I would say, that
eslint-formatter-pretty
should not specify anytypes
package as a prod dependency.The text was updated successfully, but these errors were encountered: