From ceb739ac9e79f91b23ba3a3dfe1348569b1e16f2 Mon Sep 17 00:00:00 2001 From: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Thu, 1 Feb 2024 00:04:46 +0100 Subject: [PATCH] chore: remove heavy integration tests (#6977) --- .config/nextest.toml | 4 -- .github/workflows/heavy-integration.yml | 59 --------------------- crates/forge/Cargo.toml | 3 -- crates/forge/tests/cli/heavy_integration.rs | 3 -- crates/forge/tests/cli/main.rs | 3 -- 5 files changed, 72 deletions(-) delete mode 100644 .github/workflows/heavy-integration.yml delete mode 100644 crates/forge/tests/cli/heavy_integration.rs diff --git a/.config/nextest.toml b/.config/nextest.toml index b471b448c2cc..56f40c364142 100644 --- a/.config/nextest.toml +++ b/.config/nextest.toml @@ -9,7 +9,3 @@ slow-timeout = { period = "5m", terminate-after = 4 } [[profile.default.overrides]] filter = "package(foundry-cheatcodes-spec)" retries = 0 - -[profile.heavy] -retries = 1 -slow-timeout = { period = "120m", terminate-after = 1 } diff --git a/.github/workflows/heavy-integration.yml b/.github/workflows/heavy-integration.yml deleted file mode 100644 index 8583f7bae237..000000000000 --- a/.github/workflows/heavy-integration.yml +++ /dev/null @@ -1,59 +0,0 @@ -name: heavy integration - -on: - schedule: - # Runs at 10PM utc - - cron: "0 22 * * *" - workflow_dispatch: - -env: - CARGO_TERM_COLOR: always - -jobs: - heavy-integration: - name: heavy (long-running) integration tests - runs-on: ubuntu-latest - timeout-minutes: 120 - env: - ETH_RPC_URL: https://eth-mainnet.alchemyapi.io/v2/C3JEvfW6VgtqZQa-Qp1E-2srEiIc02sD - steps: - - uses: actions/checkout@v4 - - uses: dtolnay/rust-toolchain@stable - - uses: taiki-e/install-action@nextest - - uses: Swatinem/rust-cache@v2 - with: - cache-on-failure: true - - name: Forge RPC cache - uses: actions/cache@v3 - with: - path: | - ~/.foundry/cache - ~/.config/.foundry/cache - key: rpc-cache-${{ hashFiles('crates/forge/tests/rpc-cache-keyfile') }} - - name: Setup git config - run: | - git config --global user.name "GitHub Actions Bot" - git config --global user.email "<>" - - name: Force use of HTTPS for submodules - run: git config --global url."https://github.com/".insteadOf "git@github.com:" - - name: test - run: | - cargo nextest run --profile heavy -p forge \ - --test cli --features heavy-integration-tests -E "test(~heavy_integration)" - - # If any of the jobs fail, this will create a high-priority issue to signal so. - issue: - name: Open an issue - runs-on: ubuntu-latest - needs: heavy-integration - if: ${{ failure() }} - steps: - - uses: actions/checkout@v4 - - uses: JasonEtco/create-an-issue@v2 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - WORKFLOW_URL: | - ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} - with: - update_existing: true - filename: .github/INTEGRATION_FAILURE.md diff --git a/crates/forge/Cargo.toml b/crates/forge/Cargo.toml index ac120687da2f..51b0777c05eb 100644 --- a/crates/forge/Cargo.toml +++ b/crates/forge/Cargo.toml @@ -102,9 +102,6 @@ rustls = ["foundry-cli/rustls", "reqwest/rustls-tls", "reqwest/rustls-tls-native openssl = ["foundry-cli/openssl", "reqwest/default-tls"] asm-keccak = ["alloy-primitives/asm-keccak"] -# feature for heavy (long-running) integration tests -heavy-integration-tests = [] - [[bench]] name = "test" harness = false diff --git a/crates/forge/tests/cli/heavy_integration.rs b/crates/forge/tests/cli/heavy_integration.rs deleted file mode 100644 index 1b21eb85f9eb..000000000000 --- a/crates/forge/tests/cli/heavy_integration.rs +++ /dev/null @@ -1,3 +0,0 @@ -//! Heavy integration tests that can take an hour to run or more. - -forgetest_external!(maple, "maple-labs/maple-core-v2"); diff --git a/crates/forge/tests/cli/main.rs b/crates/forge/tests/cli/main.rs index d25297119e57..e9dab70f7d1a 100644 --- a/crates/forge/tests/cli/main.rs +++ b/crates/forge/tests/cli/main.rs @@ -19,6 +19,3 @@ mod test_cmd; mod verify; mod ext_integration; - -#[cfg(feature = "heavy-integration-tests")] -mod heavy_integration;