-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Сustomizable panel name / ability to add multiple tabs #32
Comments
I can help and do this, but I wanna know your opinion about the concept. |
Hi, Panels are registered after importing I think we can make it configurable: import register from `storybook-readme/register`
register({
panels: ['README', 'DOCS', 'CHANGELOG']
}); At stories: const withChangelog = storybookReadme.at('CHANGELOG');
const withReadme = storybookReadme.at('README');
storiesOf('Button', module)
.addDecorator(withChangelog(ButtonChangelog))
.addDecorator(withReadme(ButtonReadme)) And we should hide panel if it is unused at active story. |
@ndelangen What do you think about this? |
Yeah, sounds good! |
@SuperOl3g if it is not possible to hide panels - this feature will be not so useful. If there is story without docs / changelog / readme / etc. - all panels will be shown and with empty content. But we can contribute to storybook :) Suggest "Hide panels" feature |
@SuperOl3g @tuchk4 I'm working on improving the extensibility of Storybook to make these things much easier. Not just to make addons hidable, I think that would be selling a faster horse. What I'm working on is a re-implementation of the core ui layout. It would allow users to show multiple addons at once, in any split-configuration they please. It's likely a 3.4 feature |
So multiple tabs with different docs will not be useful (until it is possible to hide tab if there is no assigned doc). @SuperOl3g Actually we can implement tabs inside main tab. If you would like to implement it - I will be happy. Consider that the same behaviour should be implemented for |
@tuchk4 Sorry, I think this solution doesn't look cool enough. |
This is feature is not useful until it is not possible to hide panels. Please reopen if you have another idea how to implement it :) |
affirmative) |
@SuperOl3g Join me on the Storybook slack and we can discuss how we can co-dev this feature. I would be super happy to peer with you on this! |
I've opened a PR here: |
Firstly great thanks for such useful plugin!
Secondly How about add ability to create multiple tabs with docs.
I think "README" + "CHANGELOG" is pretty frequent case.
The text was updated successfully, but these errors were encountered: