Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move forward to latest Antlr #378

Open
RobertvanderHulst opened this issue Aug 31, 2022 · 6 comments
Open

Move forward to latest Antlr #378

RobertvanderHulst opened this issue Aug 31, 2022 · 6 comments

Comments

@RobertvanderHulst
Copy link

Sam,
Have you ever tried to move this code forward to the latest Antlr.
I have tried to replace your code with Antlr 4.10.1 and (after changing the case for some methods and properties and after removing the optimization calls on the parser.Interpreter) I could get it to compile and run, but that code was a lot slower.
It would be nice if you could make this compatible with Antlr 4.10.1 and keep the speed.

@PatrickHofman
Copy link

I am looking in to this too. Ik have a hard time getting the maven script up and running so I can build the MSBuild targets. @sharwell is there any documentation on this?

@PatrickHofman
Copy link

@RobertvanderHulst how is your maven? Maybe we can work together on this.

@RobertvanderHulst
Copy link
Author

@PatrickHofman I am not using maven. I was building it locally.

@PatrickHofman
Copy link

PatrickHofman commented Oct 18, 2022

Okay. I think I prefer the Maven route, since it included building the ANTLR + CS targets and doing all the packaging too. You have been focusing on getting the actual C# target, right?

@lextm
Copy link

lextm commented Sep 9, 2023

Related to #381. New packages start to take over, so this repo is no longer needed.

@RobertvanderHulst
Copy link
Author

Related to #381. New packages start to take over, so this repo is no longer needed.

My latest tests show that the new Antlr packages are still much slower for large syntaxes.
It would be nice if the optimizations in this branch could be merged in the main Antlr.
I looked at it, and that is too complicated for me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants