Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.4.2 has breaking change math.div #1230

Open
MartinSoderholm opened this issue Mar 3, 2022 · 3 comments
Open

3.4.2 has breaking change math.div #1230

MartinSoderholm opened this issue Mar 3, 2022 · 3 comments

Comments

@MartinSoderholm
Copy link

Upgrading from 3.4.1 to 3.4.2 results in bunch of errors like below during build.

Error: Module build failed (from ../../node_modules/sass-loader/dist/cjs.js):
SassError: Invalid CSS after "...     floor(math": expected expression (e.g. 1px, bold), was ".div($grid-gutter-w"
        on line 369 of ../../node_modules/bootstrap-sass/assets/stylesheets/bootstrap/_variables.scss
        from line 2 of src/AppView/style.scss
>> vbar-padding-horizontal:        floor(math.div($grid-gutter-width, 2)) !defa
   ------------------------------------------^

Using:
node v16.13.2
npm 8.5.2
webpack 5.69.1
sass-loader 12.6.0
@Eseperio
Copy link

Eseperio commented Mar 8, 2022

see #1228

lucy-vxt added a commit to lucy-vxt/electron-release-server that referenced this issue May 12, 2022
@lucy-vxt
Fixing bug with bootstrap-sass.
4e5a118 
Newer versions of bootstrap-sass-official are not compatible with the version of sass used in this project as it includes changes to the way division works. This issue is documented in these issues; twbs/bootstrap-sass#1231 and twbs/bootstrap-sass#1230. Making the version of bootstrap-sass required more specific stops the breaking upgrade.
@lucy-vxt lucy-vxt mentioned this issue May 12, 2022
Merged
ArekSredzki pushed a commit to ArekSredzki/electron-release-server that referenced this issue May 12, 2022
@lucy-vxt
Fixing bug with bootstrap-sass. (#291)
fd17c29 
Newer versions of bootstrap-sass-official are not compatible with the version of sass used in this project as it includes changes to the way division works. This issue is documented in these issues; twbs/bootstrap-sass#1231 and twbs/bootstrap-sass#1230. Making the version of bootstrap-sass required more specific stops the breaking upgrade.
@alghouliammar1
Copy link

alghouliammar1 commented Jun 20, 2022 •
edited
Loading

thank you @lucy-vxt for ur suggestion it works with me

emodric added a commit to netgen-layouts/layouts-ui that referenced this issue Jul 6, 2022
@emodric
Limit bootstrap-sass to 3.4.1 to fix issues with the build
6cfc3f0 
twbs/bootstrap-sass#1230
@RobertDS07
Copy link

thank you @lucy-vxt for ur suggestion it works with me too

aminvakil added a commit to aminvakil/sportify that referenced this issue Nov 11, 2022
@aminvakil
bootstrap-sass 3.4.2 and above do not work
5474a44 
twbs/bootstrap-sass#1230
aminvakil added a commit to aminvakil/sportify that referenced this issue Nov 11, 2022
@aminvakil
bootstrap-sass 3.4.2 and above do not work
25ac5de 
twbs/bootstrap-sass#1230
(cherry picked from commit 5474a44)
@FVKVN FVKVN mentioned this issue Feb 13, 2023
Closed
@oleg-nenashev oleg-nenashev mentioned this issue Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MartinSoderholm @Eseperio @alghouliammar1 @RobertDS07