Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css/Sass changes warning #1250

Open
rcsAlex opened this issue Jul 31, 2024 · 0 comments · May be fixed by #1254
Open

Css/Sass changes warning #1250

rcsAlex opened this issue Jul 31, 2024 · 0 comments · May be fixed by #1254

Comments

@rcsAlex
Copy link

rcsAlex commented Jul 31, 2024

CSS is changing the way it handles declarations mixed with nested rules, Sass (and therefore sass-loader) are making changes to match its behavior.

Current versions that I am using:

"bootstrap-sass": "^3.4.1",
"sass-loader": "^15.0.0"

The console warning

WARNING in  <removed>
node_modules/css-loader/dist/cjs.js??clonedRuleSet-5.use[1]!./node_modules/sass-loader/dist/cjs.js??clonedRuleSet-5.use[2]!./<removed>)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 101, column 2 of file:///Users/<path>/node_modules/bootstrap-sass/assets/stylesheets/bootstrap/_navbar.scss:101:2:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

101 |   position: fixed;


node_modules/bootstrap-sass/assets/stylesheets/bootstrap/_navbar.scss 102:3  @import
node_modules/bootstrap-sass/assets/stylesheets/_bootstrap.scss 31:9          @import
app/javascript/src/stylesheets/pdf.scss 2:9                                  root stylesheet

 @ ./node_modules/mini-css-extract-plugin/dist/loader.js??clonedRuleSet-5.use[0]!./node_modules/css-loader/dist/cjs.js??clonedRuleSet-5.use[1]!./node_modules/sass-loader/dist/cjs.js??clonedRuleSet-5.use[2]!.

The styles at https://github.com/twbs/bootstrap-sass/blob/master/assets/stylesheets/bootstrap/_navbar.scss#L101 need to be moved to the top of the block so that they continue to render the same going forward.

I'm happy to open a MR to fix this myself

@mechanicalgux mechanicalgux linked a pull request Oct 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant