Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel code partially doesn't use vendor-prefixes mixins #759

Closed
komor72 opened this issue Oct 30, 2014 · 6 comments
Closed

Carousel code partially doesn't use vendor-prefixes mixins #759

komor72 opened this issue Oct 30, 2014 · 6 comments
Milestone

Comments

@komor72
Copy link

komor72 commented Oct 30, 2014

See my original issue on the Less source code:
twbs/bootstrap#14937

I just wanted to open an issue in Sass repository to make sure it's properly resolved.

@eatse21
Copy link

eatse21 commented Nov 6, 2014

Same problem here with Safari 7.1 OSX 10.9.5
I'm using your fix for the moment, thanks

@cvrebert
Copy link
Collaborator

Closing in favor of the upstream issue.

@cvrebert
Copy link
Collaborator

Hmm, actually, not sure what the Sass port's policy on prefixing/autoprefixer is, so I'll keep this open. Sorry for the spam.

@cvrebert cvrebert reopened this Nov 11, 2014
@komor72
Copy link
Author

komor72 commented Nov 12, 2014

Yes, please. The autogenerated Sass fork is IMO broken in this regard, only the Less code generates final CSS files properly.

@glebm
Copy link
Member

glebm commented Nov 12, 2014

The LESS version does not use vendor prefixes on https://github.com/twbs/bootstrap/blob/master/less/carousel.less#L30, but compiles correctly only because the LESS version is compiled using autoprefixer. As we still support vendor prefixes (though deprecated) in v3, this should be fixed upstream.

@glebm glebm closed this as completed Nov 12, 2014
@jonesmac
Copy link

I have to say this messed me up for a few days. Safari still requires vendor prefixes to use transform properly. http://caniuse.com/#feat=transforms3d
Therefore, in the current version, all safari browsers (including ios) do not have carousel support. I would recommend merging autoprefixer as a dependancy into 3.3.1 asap to fix this.

@glebm glebm added this to the v3.3.2 milestone Nov 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants