Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not the correct size in the text input if I use the .form-group-lg in a horizontal form #823

Closed
Nikolay-Lipovtsev opened this issue Jan 15, 2015 · 2 comments

Comments

@Nikolay-Lipovtsev
Copy link

When I create a horizontal form with class size, the text input is generated with incorrect height. It is created with height 68px (the correct height for the Bootstrap official documentation is 46px).

This is my html:

<form role="form" class="form-horizontal" id="new_user" action="/users" accept-charset="UTF-8" method="post">
  ...
  <div class="form-group form-group-lg">
    <label class="control-label col-sm-2" for="user_name">Control size</label>
    <div class="col-sm-10">
      <input class="form-control" type="text" name="user[name]" id="user_name">
    </div>
  </div>
</form>

I think this is happening because in CSS of .form-group.form-group-lg > .form-control remains height: auto;

This is my large input:
2015-01-14 19 11 39

This is normal large input:
2015-01-14 19 12 18

CSS:
2015-01-15 8 06 33

When I use http://maxcdn.bootstrapcdn.com/bootstrap/3.3.1/css/bootstrap.min.css instead of bootstrap-sass it is ok.

I use:
Safari 8.0.2 (10600.2.5)

Gems:
rails 4.2.0
sass-rails 4.0.5
sass 3.2.19
bootstrap-sass 3.3.1.0

@glebm
Copy link
Member

glebm commented Jan 15, 2015

Possibly related: twbs/bootstrap#15074 and #763

@glebm
Copy link
Member

glebm commented Jan 15, 2015

Confirmed with branch next output, and this is indeed the same issue as #763. Fixed on branch next, to be released in v3.3.2.

@glebm glebm closed this as completed Jan 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants