Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divorce functionality and visual style in carousel controls #10831

Closed
will-e-yams opened this issue Sep 27, 2013 · 2 comments
Closed

Divorce functionality and visual style in carousel controls #10831

will-e-yams opened this issue Sep 27, 2013 · 2 comments

Comments

@will-e-yams
Copy link

In order to customize the prev/next buttons (with, say, an icon), it is also required to recreate about half the styles associated with .icon-next and .icon-prev. This is because these styles also include

  .icon-prev {
    &:before {
      content: '\2039';// SINGLE LEFT-POINTING ANGLE QUOTATION MARK (U+2039)
    }
  }
  .icon-next {
    &:before {
      content: '\203a';// SINGLE RIGHT-POINTING ANGLE QUOTATION MARK (U+203A)
    }
  }

I suggest additional classes created .icon-prev-indicator and .icon-next-indicator that just has the content associated with it. these names would avoid any existing icon conflict both in glyphicons and font awesome.

this is how it currently works (ripped from the sample site)
http://jsfiddle.net/Y9HnH/

how i think it should work
http://jsfiddle.net/fwqvK/


A similar complaint could be made about background styles applied via .carousel-control.left and .carousel-control.right

@quasipickle
Copy link
Contributor

+1 Just came across this because I use FontAwesome instead of glyphicon. I had to add the .glyphicon* classes even though I don't use the icons, just to get the positioning styles.

@mdo
Copy link
Member

mdo commented Nov 17, 2013

Unfortunately we cannot change the class names until v4. We could deprecate these, but I shy away from that approach given it leaves busted and duplicate code lying around.

@mdo mdo closed this as completed Nov 17, 2013
@mdo mdo mentioned this issue Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants