Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading classes (.h2, .h2, etc.) override <a> and .text-* class color styling #11515

Closed
dzwillia opened this issue Nov 18, 2013 · 1 comment
Closed
Labels
Milestone

Comments

@dzwillia
Copy link
Contributor

Heading classes (.h1, .h2, etc.) override anchor tag color styling as well as other well-defined classes for color styling (.text-success, .text-danger, etc.).

It should be noted that this styling was correct shortly ago in BS 3.0.0, so I should be able to track down the change and why it was made -- the fix may be as simple as removing "color: inherit" from .h1, .h2, etc. classes.

I have included two examples to document the issue:

Bootstrap 3.0.0 (styled correctly): http://jsfiddle.net/MYrV4/3/
Bootstrap 3.0.2 (styled incorrectly): http://jsfiddle.net/5g7WH/2/

While related to Issue #10202, I view this to be a far more grievous bug than is listed the one listed there as it is more far-reaching (affecting elements all the way down to anchor tag styling).

I will create a quick pull request to fix this issue.

@dzwillia
Copy link
Contributor Author

dzwillia commented Dec 1, 2013

Great to see this made it into 3.0.3! Thanks, @mdo!

stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
@mdo mdo mentioned this issue Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant