Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collapse.js data-parent requires .panel #11606

Closed
dancek opened this issue Nov 25, 2013 · 2 comments
Closed

collapse.js data-parent requires .panel #11606

dancek opened this issue Nov 25, 2013 · 2 comments

Comments

@dancek
Copy link
Contributor

dancek commented Nov 25, 2013

The collapse js plugin should be made more flexible by not requiring a wrapping .panel for data-parent to work. The "show only one at a time" functionality is useful outside of accordions and without panel-like styling.

Fixing this is as easy as changing the selector in https://github.com/twbs/bootstrap/blob/v3.0.2/js/collapse.js#L51 to something purely semantic that doesn't come with styles -- try > .collapse-group > .in for example.

Also note that the docs do not explicitly mention what the DOM should be for data-parent to work.

See also discussion in #10023.

@cvrebert
Copy link
Collaborator

Duplicate of #10966. Please search next time.

@dancek
Copy link
Contributor Author

dancek commented Nov 25, 2013

I did, but only found #10023 (with your suggestion of creating a new issue, which I did not find). Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants