Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form-inline doesn't handle input-groups correctly #12759

Closed
mschipperheyn opened this issue Feb 16, 2014 · 2 comments
Closed

Form-inline doesn't handle input-groups correctly #12759

mschipperheyn opened this issue Feb 16, 2014 · 2 comments
Labels
css
Milestone
v3.2.0

Comments

@mschipperheyn
Copy link

In #9382 a problem was referenced with input-groups not being handled correctly. It was marked as solved, but it isn't. In 9382 a size is used to get the form-group to handle correctly. However, this defeats the concept of graceful scaling to mobile screens, even with a max-width.

http://jsfiddle.net/tZCm2/

shows the problem against TWBS 3.1.1.

Scale the result pane to a sufficient size to see the inline problem.
@cvrebert cvrebert added this to the v3.2.0 milestone Feb 16, 2014
@cvrebert cvrebert added the css label Feb 16, 2014
@saas786
Copy link
Contributor

saas786 commented Feb 20, 2014

I think needs attention.

@mdo mdo closed this as completed in a15c244 Mar 10, 2014
@mdo mdo mentioned this issue Mar 10, 2014
Closed
mrmrs pushed a commit that referenced this issue Mar 10, 2014
Merge branch 'master' into modular-the-mixins
2f380a9 
* master:
  Replace some images on the Carousel example with some base64 encoded 1x1 gifs
  ugh grunt
  moar grunt
  mo copy
  http://www.youtube.com/watch?v=AJWtLf4-WWs
  grunt
  Copy change
  fix grammar in comment in forms.less
  Fixes #12759
  Fixes #12738
  replace .visible-{size} with .visible-{size}-{display} ; fixes #8869

Conflicts:
	dist/css/bootstrap-theme.css.map
	dist/css/bootstrap.css.map
	docs/assets/js/customize.min.js
	docs/assets/js/raw-files.min.js
	docs/dist/css/bootstrap-theme.css.map
	docs/dist/css/bootstrap.css.map
	less/mixins.less
@cvrebert cvrebert mentioned this issue Jul 29, 2014
Closed
@cvrebert cvrebert mentioned this issue Nov 3, 2014
Closed
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
@mdo
(less) Fixes twbs#12759
50589f7 
Ensures proper sizing and alignment of input groups within inline and
navbar forms.

* Uses `inline-table` on the input group
* Nukes the widths to `width: auto`—without this, the parent input
group doesn’t size correctly and functions as `display: table;` or
`block`
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
(less) Merge branch 'master' into modular-the-mixins
9129fb6 
* master:
  Replace some images on the Carousel example with some base64 encoded 1x1 gifs
  ugh grunt
  moar grunt
  mo copy
  http://www.youtube.com/watch?v=AJWtLf4-WWs
  grunt
  Copy change
  fix grammar in comment in forms.less
  Fixes twbs#12759
  Fixes twbs#12738
  replace .visible-{size} with .visible-{size}-{display} ; fixes twbs#8869

Conflicts:
	dist/css/bootstrap-theme.css.map
	dist/css/bootstrap.css.map
	docs/assets/js/customize.min.js
	docs/assets/js/raw-files.min.js
	docs/dist/css/bootstrap-theme.css.map
	docs/dist/css/bootstrap.css.map
	less/mixins.less
@amazingandyyy
Copy link

I face the same issue help

@twbs twbs locked and limited conversation to collaborators Jan 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
css
Projects
None yet
Milestone
v3.2.0
Development

No branches or pull requests
4 participants
@mschipperheyn @cvrebert @saas786 @amazingandyyy