Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customiser: Color preview with color variables #12921

Closed
lungyiing opened this issue Mar 4, 2014 · 7 comments
Closed

Customiser: Color preview with color variables #12921

lungyiing opened this issue Mar 4, 2014 · 7 comments

Comments

@lungyiing
Copy link

Using javascript to automatically update a small preview for colour variables on the customiser (perhaps using input groups).

For example:

@cvrebert
Copy link
Collaborator

cvrebert commented Mar 4, 2014

Duplicate of #11904.

@cvrebert
Copy link
Collaborator

cvrebert commented May 7, 2014

I'm thinking that we could use an <input type="color"> polyfill for this.
My current polyfill recommendation would be https://github.com/bgrins/spectrum

@mdo
Copy link
Member

mdo commented May 8, 2014

Hah, having just played with Spectrum for something else, fuck that. Maybe we do just rock the color input and make that an enhancement for folks in particular browsers?

@mdo
Copy link
Member

mdo commented May 8, 2014

Only latest Chrome and Firefox support the color input FYI.

@cvrebert
Copy link
Collaborator

cvrebert commented May 8, 2014

We could just leave it as a text field and add a preview swatch (like in the above mockup). Would be pretty easy. I'd guess most folks are gonna copy-paste in colors anyway, rather than coming up with them on the spot.
Slight caveat with any of the approaches is that they don't let you preview Less color expressions (short of adding a good chunk of JS to hook into the Less compiler more).

@mdo
Copy link
Member

mdo commented May 9, 2014

I think given that this makes the most sense to save for v4 or v5 when we can simplify things a bit more.

@cvrebert cvrebert added this to the v4.0.0 milestone Jul 8, 2014
@mdo
Copy link
Member

mdo commented Aug 2, 2014

Closing and punting to our v4 list.

@mdo mdo closed this as completed Aug 2, 2014
@mdo mdo removed this from the v4.0.0 milestone Aug 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants