-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse should use touchstart event on touch devices #13036
Comments
On what browser & OS? If this is on a touch device, have you checked whether |
It is on Chrome (iOS and Android) and Mobile Safari. |
Nope, as it is the same issue in Safari and Chrome on iOS |
@romancieslik AFAIK, that doesn't have any bearing on my previous question. |
Oops, to answer your question: The issue persist on Android’s latest Chrome. |
We have to test the touch support first, then change it. |
Great. Looking forward to your investigation results. |
There isn't the right way for the touch support detection. We can implement the current one that Modernizr have. We have to do: // some way to check touch support
// ...
if (touchsupport) {
event = touchstart.bs.collapse.data-api
}
else {
event = click.bs.collapse.data-api
} I don't have any other ideas. |
Sounds like a workaround, but good enough for our purposes. |
@mdo @fat Should we do something about this? Maybe punt to v4? |
Yeah touch start is definitely faster. I'd like to rethink a lot of our components for mobile in v4. This would be a good candidate for that imho |
Punting to v4. |
When collapsing the navbar-collapse, it takes around 1 second for the menu to respond to the event. Changing the event from
to
solved this for us. The menu reacts almost instantly then.
Do you plan to make this event configurable?
The text was updated successfully, but these errors were encountered: