Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical scrolling buggy when modal height larger than browser window in Chrome on Nexus 7 #13628

Closed
henrywright opened this issue May 19, 2014 · 14 comments
Labels

Comments

@henrywright
Copy link

I'll try my best to explain this one...

When a modal is larger than the height of the browser in Chrome on my Google Nexus 7 and I try to scroll down using a finger swipe, unless my finger is touching the actual modal when I swipe, the modal does not scroll.

To reproduce:

  1. Set up a modal-sm sized modal with lots of content in it so that the modal height is larger than the browser window.
  2. Attempt to scroll down by finger swiping but make sure you finger swipe outside of the .modal element.

Scrolling doesn't seem to happen.

However, if you retry step 2 but ensure you finger swipe downwards inside the .modal element, scroll will work.

@cvrebert cvrebert added the css label May 19, 2014
@cvrebert cvrebert added this to the v3.2.1 milestone May 19, 2014
@cvrebert
Copy link
Collaborator

What version of Chrome? What version of Android? You're using Bootstrap v3.1.1, correct?

@henrywright
Copy link
Author

Sorry, yes.

Bootstrap 3.1.1
Android 4.4.2
Chrome 34.0.1847.114

@henrywright henrywright changed the title Vertical scrolling buggy when model height larger than browser window in on Nexus 7 Vertical scrolling buggy when model height larger than browser window in Chrome on Nexus 7 May 19, 2014
@henrywright
Copy link
Author

Just to add, I did some cross-browser testing in FireFox 29.0.1 and the problem does not exist there.

@cvrebert cvrebert changed the title Vertical scrolling buggy when model height larger than browser window in Chrome on Nexus 7 Vertical scrolling buggy when modal height larger than browser window in Chrome on Nexus 7 May 20, 2014
@cvrebert
Copy link
Collaborator

Testcase: http://jsfiddle.net/vvZdg/2/show/

@cvrebert
Copy link
Collaborator

I am unable to reproduce the issue with Android 4.4.2 on a Nexus 10 using Chrome 34.0.1847.114.

@cvrebert cvrebert removed this from the v3.2.1 milestone May 22, 2014
@cvrebert
Copy link
Collaborator

@henrywright Can you check whether the testcase I posted works for you or not?

@henrywright
Copy link
Author

@cvrebert just tested the example you set up which works for me. I also set up my own test case http://jsfiddle.net/K9Dar/show/ which uses the default Bootstrap markup. This also works for me. Closing this until I can better pinpoint the problem (if there is one)

@kntmrkm
Copy link

kntmrkm commented Dec 20, 2014

In my case, It happens when add below script to prevent body scrolling.
I have followed this doc.
http://getbootstrap.com/getting-started/#support-fixed-position-keyboards

  var modal = $('.modal');
  if (Modernizr.touch) {
    $(document).on('show.bs.modal', function(e) {
      scrollLocation = $(window).scrollTop();
      modal.css({
        marginTop: scrollLocation + 'px',
        position: 'absolute',
        bottom: 'auto'
      });
  }

I have tested in below environment.

  • Bootstrap-sass(Rails gem) 3.3.1.0
  • Genymotion 2.3.1
  • Samsung Galaxy S5 4.4.4
    • Android browser (default) ver 4.4.4-eng.buildbot.20141001.101335
    • This browser is chrome's version? right?
  • Google Nexus 7 2013 default Android Browser can't scroll too.

On the other version, Sumsung Galaxy S2 4.1.1 is works well.
That is a Non-Chrome Android Browser.

Adding to above, Google Nexus 7 - 5.0.0 is works well.
Just 4.4.4 version is problem maybe.

Chome version detail (Defualt Android Browser)

  • Android 4.1.1 : Android 4.0.0 → able to scroll
  • Android 4.2.2 : Android 4.0.0 → able to scroll
  • Android 4.3 : Android 4.0.0 → able to scroll
  • Android 4.4.4 : Chrome 33.0.0.0 → unable to scroll
  • Android 5.0.0 : Chrome 37.0.0.0 → able to scroll

jsfiddle is
http://jsfiddle.net/kntmrkm/kauhLbk0/3/show/

sorry. Above fiddle can't reproduce mobile view. so iOS safari can not scroll too.

@cwohlman
Copy link

I've got a reproduction for this bug on Chrome desktop, but it depends on bootboxjs... http://embed.plnkr.co/7oLaRa9LUpwc7D0OSUJ3/preview

@twbs-lmvtfy
Copy link

Hi @cwohlman!

You appear to have posted a live example (http://run.plnkr.co/plunks/7oLaRa9LUpwc7D0OSUJ3/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

  • W001: <head> is missing UTF-8 charset <meta> tag
  • W002: <head> is missing X-UA-Compatible <meta> tag that disables old IE compatibility modes
  • W003: <head> is missing viewport <meta> tag that enables responsiveness
  • line 5, column 5: W013: Bootstrap version might be outdated. Latest version is at least 3.3.1 ; saw what appears to be usage of Bootstrap 3.2.0
  • line 7, column 5: W013: Bootstrap version might be outdated. Latest version is at least 3.3.1 ; saw what appears to be usage of Bootstrap 3.2.0

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!

(Please note that this is a fully automated comment.)

@cwohlman
Copy link

How about this:

http://plnkr.co/edit/7oLaRa9LUpwc7D0OSUJ3

@twbs-lmvtfy
Copy link

Hi @cwohlman!

You appear to have posted a live example (http://run.plnkr.co/plunks/7oLaRa9LUpwc7D0OSUJ3/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

  • W003: <head> is missing viewport <meta> tag that enables responsiveness
  • line 8, column 5: W013: Bootstrap version might be outdated. Latest version is at least 3.3.1 ; saw what appears to be usage of Bootstrap 3.2.0
  • line 10, column 5: W013: Bootstrap version might be outdated. Latest version is at least 3.3.1 ; saw what appears to be usage of Bootstrap 3.2.0

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!

(Please note that this is a fully automated comment.)

@cwohlman
Copy link

@cvrebert
Copy link
Collaborator

If there's any issue here still present in v3.3.2, please open a new issue.
Also, in general, we advise against commenting on issues that were closed over 6 months ago as nobody is likely to be watching them anymore, and your comments will thus go unheard.

@twbs twbs locked and limited conversation to collaborators Feb 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants