Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar example uses markup against doc recomendations #15512

Closed
flevour opened this issue Jan 7, 2015 · 4 comments
Closed

Navbar example uses markup against doc recomendations #15512

flevour opened this issue Jan 7, 2015 · 4 comments

Comments

@flevour
Copy link

flevour commented Jan 7, 2015

The code for this example uses nested containers (the root one plus one inside navbar): http://getbootstrap.com/examples/navbar/

This example should be updated to reflect the fact that nested containers have been deprecated (#11436), or should have a comment explaining why the exception is fine in this case.

@cvrebert cvrebert added this to the v3.3.2 milestone Jan 7, 2015
@mdo
Copy link
Member

mdo commented Jan 7, 2015

There's no problem here—navbars require the use of a container within them, and there's a site-wide container to center the page contents. One is .container, the other is .container-fluid. The issue of #11436 is that for awhile our .containers used fixed widths, not max-widths. Thus, we use .container-fluid on a required nested container.

@mdo mdo closed this as completed Jan 7, 2015
@mdo mdo removed this from the v3.3.2 milestone Jan 7, 2015
@cvrebert
Copy link
Collaborator

@mdo Wait, so only .container isn't nestable within .container or .container-fluid?

@CorpusCallosum
Copy link

THE ISSUE is that the documentation does not reflect this:
"Bootstrap requires a containing element to wrap site contents and house our grid system. You may choose one of two containers to use in your projects. Note that, due to padding and more, neither container is nestable."

http://getbootstrap.com/css/

@iatek
Copy link
Contributor

iatek commented Apr 14, 2016

This recently came up as an issue on StackOverflow:
http://stackoverflow.com/questions/36618433/bootstrap-navbar-should-i-nest-containers/36621583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants