Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better naming for enable Right-To-Left support #16419

Closed
oriSomething opened this issue May 4, 2015 · 3 comments
Closed

better naming for enable Right-To-Left support #16419

oriSomething opened this issue May 4, 2015 · 3 comments
Labels

Comments

@oriSomething
Copy link

i guess it would be more relevant in BS4, but still, i think we can have better naming so it will be easier to have support when needed to RTL to multi languages site:
.pull-left -> .pull-start
.pull-right -> .pull-end

same with texts:
.text-left -> .text-start
.text-right -> .text-end

so if there is .text-left in addition, it will always be aligned to left and won't have unexpected behavior.
the reason is when you make RTL support, many times you'll have to support multi languages with both LTR and RTL directions on the same page. so this naming convension, can make it much easier and more clearer for the developer

@Natshah
Copy link

Natshah commented May 4, 2015

This is a very good idea . I do like it.

And the start and end can work for Horizontal and Vertical too.

I do have this repository about Bootstrap Pull 3.x-1.1.1
https://github.com/Natshah/bootstrap-pull

I had a hint at this issue #13690
Punting to v4

Thanks.

@cvrebert cvrebert added the css label May 4, 2015
@cvrebert
Copy link
Collaborator

cvrebert commented May 4, 2015

Noted for consideration for Bootstrap v4.

@cvrebert cvrebert closed this as completed May 4, 2015
@oriSomething
Copy link
Author

@cvrebert by the way, i use this kind of code for building RTL and LTR versions:

.text-start {
  @if $is-rtl {
    text-align: right;
  } @else {
    text-align: left;
  }
}

@twbs twbs locked and limited conversation to collaborators May 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants