Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of remote Modal content with transitions #18275

Closed
joshreed opened this issue Nov 16, 2015 · 1 comment
Closed

Better handling of remote Modal content with transitions #18275

joshreed opened this issue Nov 16, 2015 · 1 comment
Labels

Comments

@joshreed
Copy link

Currently, remote content, unless loaded really quickly, or already cached in-browser, will not always show the (CSS) transitions, which is a nuisance. This is because the transition "starts" using an empty DIV, and often the content hasn't arrived until after the div has already been "transitioned" in.

I have a Pull Request with a fix, however it currently is failing on the @twbs-savage test, it errors with a 10 minute timeout in trying to connect. Is this an issue with the continuous-integration process, or the code itself?

#18274

In any case, I'm not tied to this particular solution presented in the Pull Request, but I figured it'd be valuable to not only supply a "complaint" but also a way to fix it! If there's a different preferred implementation that fixes the root issue, I'm certainly open to it.

@joshreed joshreed changed the title Better handling of remote content with transitions Better handling of remote Modal content with transitions Nov 16, 2015
@cvrebert
Copy link
Collaborator

The remote option is deprecated (see http://getbootstrap.com/javascript/#modals-options & #14034) and Bootstrap v3 is in maintenance mode at this point so we can focus on v4.
Since the issue isn't a showstopper and concerns a deprecated feature, I'm calling this WontFix. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants