Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form styles are dependent on markup #189

Closed
corroded opened this issue Sep 10, 2011 · 2 comments
Closed

Form styles are dependent on markup #189

corroded opened this issue Sep 10, 2011 · 2 comments

Comments

@corroded
Copy link

HI just wanted to comment that some of us don't actually use divs for forms(formtastic, etc) and it would probably be a good idea to make them markup independent? By default we have div.input, but it would be better if it was just plain .input, so we can also apply that to <li>s for example.

Is this a good path to take? If so I can probably help out with this :)

@benschwarz
Copy link

@mdo
Copy link
Member

mdo commented Sep 10, 2011

Yeah, overqualifying is bad. Removing the div from div.input in 1.3-wip branch right now. Will now just be form .input so that it is at least scoped to the form styles.

We can revisit changing the form markup in v2.0 since that'd change a lot of markup and classes, but for now in the default form styles the .input has to stay. It's also worth noting that the .input div does not exist in the stacked forms. You can use that if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants