-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 Alpha 3 references nonexistent dist/js/npm.js in package.json #20383
Comments
@cvrebert Is this something we need to restore, or is there another solution here? I'm unsure what I can do to resolve this and, if there's a fix, I'd like to include it in the "alpha patch" I've queued up. |
I'm not entirely sure about the decision to only ship ES6 files in the npm package, introduced by #20072... In the application I'm working on, we do indeed have Babel + Webpack, but we only run it on our own source files (and with Babel presets specific to our project, since there are different "flavors" of ES6). All the packages in our Our use-case is that we only bundle the JS we need from Bootstrap. An example from one of our Webpack entry points: window.jQuery = require('jquery');
require('bootstrap/dist/js/umd/dropdown.js'); This would work if we required ES5 CommonJS (it doesn't have to be UMD), but it wouldn't if it was ES6. Long story short, I would publish on npm:
(Folder names are given as example, feel free to change them.) Others may have different opinions, but I just wanted to raise a flag on publishing only the ES6 modules and full UMD build 😄 I think we should also have the ES5 CommonJS. |
@mdo No need to resurrect anything. Probably we should change |
looks like #20394 is doing just that |
I am having the same issue as @TheSharpieOne, it is kinda unfortunate that I have to go back to alpha2 because of it. Or does anyone have a workaround for this? Small side-question: why is it still called an alpha? Isn't it stable enough to call it a beta? Or do you want to call it a beta when most of the breaking changes have been released? |
@Zyphrax the current workaround is to change |
Thank you. I'm importing the (s)css of Bootstrap in my project (es6 notation). That seems to trigger Webpack to include the javascript code of Bootstrap and then throws an error that the bootstrap module could not be found. I'm not really sure how I can work around that. |
The v4 alpha 3 (just released) npm package does not contain as ./dist/js/npm referenced in the package.json.
This causes problems when requiring or importing the bootstrap package via npm.
I am not sure if the file is missing or purposely removed (in which case the package.json would need to be updated)
Update:
Commit which removed the file: ce2e944
The text was updated successfully, but these errors were encountered: