-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit text-hide mixin #24890
Comments
Isn't One could easily use |
@moso The goal of text hiding is to visually hide the text while still rendering the element's overall size and shape, often with a |
That said, it is an old technique :). |
We're kinda stuck with this now that we're heading to v4 stable. We could drop it, but it'd technically be a breaking change. Thoughts? |
Leave it in, and maybe do a |
i'd say remove the whole image replacement thing in 4.1 (or do an unscheduled breaking change, nobody would die from that presumably). maybe replace with more modern approaches (e.g. using |
Let's deprecate for 4.1 or 4.2 if we can. |
@mdo What is the rationale behind removing this helper? As I still regularly use it for logos in website headers, i.e. <a class="header-logo" href="/">
<span class="header-logo-text">Website Name</span>
</a> .header-logo-text {
@include text-hide();
width: 200px;
height: 100px;
background: url(../img/logo.png);
} Is there an alternative to this technique that I should be using…? |
This helper comes from html5 Boilerplate. It was removed in 2013 in this PR.
We should revisit it or remove it too.
/CC @mdo
The text was updated successfully, but these errors were encountered: