Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.carousel-fade and animated progress bar don't seem to use transition mixin #25709

Closed
patrickhlauke opened this issue Feb 25, 2018 · 2 comments
Closed

Comments

@patrickhlauke
Copy link
Member

Per #25641 (comment) is seems that even when disabling transitions (using $enable-transitions or after setting the "prefers reduced motion" option once that PR has landed), .carousel-fade (https://github.com/twbs/bootstrap/blob/3dd0bde664699fc7a191d0d3569f4f0ba8f06028/docs/4.0/components/carousel.md#crossfade) and the animated progress bar https://getbootstrap.com/docs/4.0/components/progress/#animated-stripes still use transitions. Possibly (not tested) even the JS-based fade https://getbootstrap.com/docs/4.0/components/list-group/#fade-effect

All these effects should be suppressed when $enable-transitions is off / "prefers reduced motion" is indicated by the user.

@mdo
Copy link
Member

mdo commented Jun 21, 2018

Given the referenced PR was merged, save to close?

@patrickhlauke
Copy link
Member Author

No, the referenced PR addressed the reduced motion stuff which sets/unsets the the transitions variable. This issue points out that the carousel fade and animated progress bar are not conditional on that transitions variable (regardless of whether $enable-transitions is on or off / "prefers reduced motion" is set in the UA, carousels do animated fades and animated progress bars animate - they shouldn't/should obey those)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants