Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox and radio buttons : no cursor pointer on buttons hover #28237

Closed
ghusta opened this issue Feb 11, 2019 · 6 comments · Fixed by #29239
Closed

Checkbox and radio buttons : no cursor pointer on buttons hover #28237

ghusta opened this issue Feb 11, 2019 · 6 comments · Fixed by #29239
Labels

Comments

@ghusta
Copy link

ghusta commented Feb 11, 2019

Environment

  • OS : Win 10
  • Browser : Firefox 65.0 / Chrome 72.0

Test case

Since version 4.3, when hovering the mouse pointer on a radio button within a button group (btn-group-toggle), there is no cursor pointer anymore. It worked with version 4.2.

The behaviour is the same with both examples in the documentation (group of 1 button / group of 3 buttons).

Reproducible within the documentation :

For information, I had this style enabled in version 4.2 with cursor: pointer, but not anymore in version 4.3 :

.btn:not(:disabled):not(.disabled)

@patrickhlauke
Copy link
Member

this is intended. by default, browsers don't provide a pointer cursor for checkboxes and radio buttons, so the opinionated use of cursor: pointer was moved in 4.3 - see #27021

@ghusta
Copy link
Author

ghusta commented Feb 11, 2019

Thanks for the clarification and for pointing me to this PR.
I find it strange since it primarily looks like buttons, but OK...

@patrickhlauke
Copy link
Member

(FWIW buttons also don't get a pointer cursor by default)

@ghusta
Copy link
Author

ghusta commented Feb 12, 2019

I better understand this intention by looking at these links :

But when you say that buttons don't get a pointer cursor by default, this behaviour doesn't seem to have been updated according to the documentation v4.3 ?

For example on https://getbootstrap.com/docs/4.3/components/buttons/ buttons still have a pointer cursor, whatever they are html buttons, links with role = "button", etc.

@patrickhlauke
Copy link
Member

oh, interesting. maybe i've missed one of the iterations of the overall discussion (it's been going back and forth for months/years). i'll dig in and see why we now have this mismatch again...

@patrickhlauke patrickhlauke reopened this Feb 12, 2019
@astegmaier
Copy link

I agree with @ghusta that it seems a bit strange to say at the same time "things styled with the btn class shouldn't have the hand cursor" and "<button> elements should have the hand cursor".

It looks like both changes were made in the same PR - #27021 (here and here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants