Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.progress-bar-animated ignores $enable-prefers-reduced-motion-media-query. #28528

Closed
hardaqa opened this issue Mar 19, 2019 · 3 comments · Fixed by #28530
Closed

.progress-bar-animated ignores $enable-prefers-reduced-motion-media-query. #28528

hardaqa opened this issue Mar 19, 2019 · 3 comments · Fixed by #28530

Comments

@hardaqa
Copy link

hardaqa commented Mar 19, 2019

.progress-bar-animated ignores $enable-prefers-reduced-motion-media-query

Missing condition
@if $enable-prefers-reduced-motion-media-query {
before line 39 in _progress.scss

@patrickhlauke
Copy link
Member

reduced motion is generally concerned with animations that can cause issues for users with vestibular disorders (i.e. parallax scrolling, slow animated opening/closing things). it's not necessarily a "no animations at all" setting. at this stage, we've left the animated progress bar on purpose, unless there's evidence this can cause issues to users?

@hardaqa
Copy link
Author

hardaqa commented Mar 19, 2019

You already did implement reduced-motion media query #27986. I want to enable animations in my design regardless of browser/system settings. Issue is a variable $enable-prefers-reduced-motion-media-query having no effect wether it's true or false and leaves the animation disabled on my system.

@patrickhlauke
Copy link
Member

ah, now i see what you mean - i forgot that we flipped on that one in the end. yes, since we do have a variable for reduced motion, it makes sense to add that there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants