Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit navbar-breakpoints #36517

Open
2 tasks done
pine3ree opened this issue Jun 6, 2022 · 0 comments
Open
2 tasks done

limit navbar-breakpoints #36517

pine3ree opened this issue Jun 6, 2022 · 0 comments

Comments

@pine3ree
Copy link
Contributor

pine3ree commented Jun 6, 2022

Prerequisites

Proposal

Reduce the breakpoints over which navbar (expand) classes are generated

Motivation and context

Navbar classes are generated for all breakpoints, but in most cases this could be a waste of bytes in the resulting css. We usually need just a couple of navbar-breakpoints. I suggest we use

$navbar-breakpoints: $grid-breakpoints;

in _variables.scss and loop over it in _navbar.scss

This way we can customize/reduce (e.g. $navbar-breakpoints: map-remove($grid-breakpoints, xl, xxl);) $navbar-breakpoints in our builds to the ones we actually need.

kind regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants