bootstrap-collapse.js - 2.0.4 - transition function

[stevematyas]

Chrome Linux|OSX 19.x.x.x fail to execute the inner complete() function which, resets the this.transitioning = 0 (false). The impact of which is that you are unable to re-expand a previously open & closed accordian-group element

Line numbers are off a bit due to other mods I've made locally.

$ svn diff resources/
Index: resources/bootstrap/js/bootstrap.js
===================================================================
--- resources/bootstrap/js/bootstrap.js (revision 32788)
+++ resources/bootstrap/js/bootstrap.js (working copy)
@@ -510,7 +510,8 @@

   , transition: function (method, startEvent, completeEvent) {
       var that = this
-        , complete = function () {
+      
+      var complete = function (that) {
             if (startEvent.type == 'show') that.reset()
             that.transitioning = 0
             that.$element.trigger(completeEvent)
@@ -525,8 +526,8 @@
       this.$element[method]('in')

       $.support.transition && this.$element.hasClass('collapse') ?
-        this.$element.one($.support.transition.end, complete) :
-        complete()
+        this.$element.one($.support.transition.end, complete(this)) :
+        complete(this)
     }

   , toggle: function () {

[kmiyashiro]

Can you try replacing line 55 with if (this.transitioning || this.$element.hasClass('in')) return and line 75 with if (this.transitioning || !this.$element.hasClass('in')) return ? I have a feeling that transitioning is getting stuck as 1 if you try to show/hide an already shown/hidden collapsible. Unfortunately, I can't reproduce this in qunit since the collapsible never fires shown or hidden in quint.

[fat]

Can you reopen with a demonstrable test case in either jsbin or qunit. thanks!