Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation error #40772

Closed
3 tasks done
gazhay opened this issue Aug 26, 2024 · 1 comment
Closed
3 tasks done

Documentation error #40772

gazhay opened this issue Aug 26, 2024 · 1 comment
Labels

Comments

@gazhay
Copy link

gazhay commented Aug 26, 2024

Prerequisites

Describe the issue

site/content/docs/5.3/utilities/spacing.md

The examples relating to grid gap spacing are incorrect.
They specify a class of "grid" - however that will not work - it is class "d-grid"

Reduced test cases

na

What operating system(s) are you seeing the problem on?

Windows, macOS, Android, iOS, Linux

What browser(s) are you seeing the problem on?

Chrome, Safari, Firefox, Microsoft Edge, Opera

What version of Bootstrap are you using?

v5.3.2

@louismaximepiton
Copy link
Member

louismaximepiton commented Aug 29, 2024

Hey, thanks for your contribution.

The .grid is intended here to have a grid template. The class is defined in _grid.scss. TBH, I think the implementation is correct since the .grid class exists if the $enable-cssgrid is set to true. The process is well explained in CSS grid part of the documentation. However, the concept explained here still work using flex display.
Closing the issue as duplicate of #40726 for now.

@louismaximepiton louismaximepiton closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants
@gazhay @louismaximepiton and others