Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

col-xs offset? #9689

Closed
dongepulango opened this issue Aug 16, 2013 · 12 comments
Closed

col-xs offset? #9689

dongepulango opened this issue Aug 16, 2013 · 12 comments

Comments

@dongepulango
Copy link

Is it good to have offset in col-xs? Because I'm putting an extra col that only visible in mobile just to achieve the offset. I'm not an expert on this, but I don't understand why there is no offset in col-xs.

@mdo
Copy link
Member

mdo commented Aug 16, 2013

I'm not sold that it's necessary—it's an awfully narrow viewport on phones and I can't think of that many compelling reasons to add them (and thus push/pull classes).

@mdo mdo closed this as completed Aug 16, 2013
@jonjaques
Copy link

Sure, pushing around columns on a 320px screen is probably not a great idea—but given that the smallest breakpoint is 768px, don't you think this warrants some consideration?

In fact, it almost seems contrary to the idea of "mobile-first", to not have col-offset at the smallest grid size.

Here's a use case for a login page. I don't want the lighter colored box to touch the edge of the page, but at the larger end of the breakpoint, the inputs would be comically large and that's what I'm trying to avoid here.

@hsukenooi
Copy link

Maybe a reason to include it is we're told to use .col-xs-* for a non-responsive template (http://getbootstrap.com/examples/non-responsive/). Without .col-xs-offset-* we can't use offsets in a non-responsive template.

@mdo
Copy link
Member

mdo commented Aug 19, 2013

That's a really good point actually. Hmm...

@mdo mdo reopened this Aug 19, 2013
@mdo
Copy link
Member

mdo commented Aug 19, 2013

Reopened and will slate for v3.1.

@mdo mdo mentioned this issue Aug 19, 2013
22 tasks
@dongepulango
Copy link
Author

👍 to @hsukenooi

@KOTRET
Copy link

KOTRET commented Aug 23, 2013

👍 on devices with 320px this maybe does not make much sense, but for < 768px it still does. also its not very consistent atm. also it is possible to set the breakpoints manually and force xs to be like 900 or so...

@ghost
Copy link

ghost commented Aug 30, 2013

I second that. 768px is not that small a width that would never require offsetting.

@buschtoens
Copy link

Ran into this aswell. I would really like to see those.

@halcyonandon
Copy link

I hit this same issue and I think this will be pretty common in cases where you need a responsive image to appear after a heading tag, but it visually needs to appear before it.

My use-case is, I have an article image that appears after the <h1> in the dom, but needs to visually appear before the <h1>. I use this class to rearrange. I was originally adding it to a 'collapse' menu list for xs, but my requirements have changed and I now need to use col-xs-6 with col-xs-pull-6 in combination with img-responsive to show a thumbnail version of the 300x300px image on mobile without collapsing. This will also likely be the case for the our search results' thumbnails too.

For SEO purposes, its more ideal to have an image ordered in the dom after its heading title. Also, if we decide to later collapse content by headings, this approach ensures all the content appears after it.

@cvrebert
Copy link
Collaborator

cvrebert commented Oct 7, 2013

Folks, we don't need any more "+1"s; this is already planned for v3.1.

@cvrebert
Copy link
Collaborator

Fixed by #11050.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants