Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs.css in the CSSComb task. #12861

Merged
merged 2 commits into from
Feb 27, 2014
Merged

Add docs.css in the CSSComb task. #12861

merged 2 commits into from
Feb 27, 2014

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR added this to the v3.2.0 milestone Feb 27, 2014
@XhmikosR XhmikosR self-assigned this Feb 27, 2014
@cvrebert
Copy link
Collaborator

👍

(Tangentially: Perhaps csscomb should happen before cssmin in the build?)

@XhmikosR
Copy link
Member Author

Yeah, definitely. I thought that was already the case...

@XhmikosR
Copy link
Member Author

Done.

XhmikosR added a commit that referenced this pull request Feb 27, 2014
Add docs.css in the CSSComb task.
@XhmikosR XhmikosR merged commit 4d527f9 into master Feb 27, 2014
@XhmikosR XhmikosR deleted the docs-csscomb branch February 27, 2014 08:58
@BBosman
Copy link
Contributor

BBosman commented Feb 27, 2014

If csscomb is to be run before cssmin, shouldn't it also be run before less:minify?

@XhmikosR
Copy link
Member Author

It doesn't change the less files, so it needs to be after that.

@BBosman
Copy link
Contributor

BBosman commented Feb 27, 2014

Although the name would indicate otherwise, the less:minify task doesn't operate on the less files. It creates the bootstrap.min.css (and theme) file based on the css (not less) files.

@XhmikosR
Copy link
Member Author

I misread your post ofc. less:minify can be called after csscomb. Feel free to make a PR.

@mdo mdo mentioned this pull request Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants