Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #13216 #13217

Merged
merged 1 commit into from
Apr 3, 2014
Merged

fixes #13216 #13217

merged 1 commit into from
Apr 3, 2014

Conversation

thedavidscherer
Copy link

Fixes #13216.
Change @zindex-popover and @zindex-tooltip values to be greater than
those set for @zindex-modal allowing tooltips and popovers to be
displayed in front of modals (and all other content).

change `@zindex-popover` and `@zindex-tooltip` values to be greater than
those set for `@zindex-modal` allowing tooltips and popovers to be
displayed in front of modals (and all other content).
@cvrebert cvrebert added the css label Mar 28, 2014
@cvrebert cvrebert added this to the v3.2.0 milestone Mar 28, 2014
mdo added a commit that referenced this pull request Apr 3, 2014
@mdo mdo merged commit a444863 into twbs:master Apr 3, 2014
@mdo mdo mentioned this pull request Apr 3, 2014
@thedavidscherer thedavidscherer deleted the fix-13216 branch April 3, 2014 12:43
@thedavidscherer thedavidscherer restored the fix-13216 branch April 3, 2014 12:58
@zomp
Copy link

zomp commented Aug 13, 2014

Hi, I might overlooked something but I believe this is a bug – the issue in #13216 is, in my opinion, not an error, just a wrong usage of Popover. 'body' is used as a container there, so it is a correct consequence the popover is displayed over the body there (the popover is stacked into the body instead into the modal – explanation can be found in the fourth chapter of z-index stacking rules). If you remove the 'body' container, everything works fine.

This "fix" causes a new serious issue: Unrelated Popovers and Tooltips are displayed over Modals (if you have an opened popover and you open a modal, the modal is displayed bellow).

I suggest to revert this commit and add a note into docs which would explain z-index stacking.

@cvrebert
Copy link
Collaborator

@zomp Thanks, could you please open a new issue about this?

stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover Displays Behind Modal (3.1.1)
5 participants