Configure affix target element #13342
Conversation
|
Please also include a docs update to mention this new parameter. |
| this.$window = $(window) | ||
| .on('scroll.bs.affix.data-api', $.proxy(this.checkPosition, this)) | ||
| .on('click.bs.affix.data-api', $.proxy(this.checkPositionWithEventLoop, this)) | ||
| this.$window = this.options.target ? $(this.options.target) : $(window) |
There was a problem hiding this comment.
I think $(window) might make more sense added to affix's defaults… rather then doing this check here.
There was a problem hiding this comment.
also this.$window doesn't make much sense if the target isn't the window… should probably rename that to this.$target
|
/cc @fat for final review since the requested changes have been made. |
| .on('scroll.bs.affix.data-api', $.proxy(this.checkPosition, this)) | ||
| .on('click.bs.affix.data-api', $.proxy(this.checkPositionWithEventLoop, this)) | ||
|
|
||
| this.$target = $(this.options.target) |
There was a problem hiding this comment.
you dont need this var definition to be a separate line
There was a problem hiding this comment.
look how $window was done above for ref
|
Running Sauce tests on a squashed version of this PR: https://travis-ci.org/twbs/bootstrap/jobs/25362457 |
|
Sauce tests passed. |
No description provided.