Fix popover dismiss-on-next-click example #14156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ tabindex Fixes #14038. Research supporting this choice of approach: https://gist.github.com/cvrebert/68659d0333a578d75372 Why not <button>? Even with a `tabindex` attribute, they don't gain focus when clicked upon in: * Mac OS X Firefox 30.0 * Mac OS X Safari 7.0.5
|
|
(I still stand in awe of all the research.)
|
@hnrch02 And this is why the Web's claims of cross-platform compatibility are overblown. |
|
@cvrebert Word. But that's mostly due to the fact that the Web's cross-platform compatibility depends on third parties/vendors. |
|
Nobody has objected or given criticism, so I'm gonna merge this. |
cvrebert
added a commit
that referenced
this pull request
Jul 18, 2014
Fix popover dismiss-on-next-click example
Closed
|
The research has been added to MDN for posterity: |
|
Thanks for the time put into this, it's very helpful. |
nmorduch
referenced
this pull request
in dancerfly/django-brambling
Jul 31, 2014
Resolves #114 Hopefully appropriately given my track record today.
rufuspollock
added a commit
to datahub-v2/frontend
that referenced
this pull request
Nov 18, 2017
…o fix display bug in safari - fixes #132. Bug: in Safari popover does not show preventing people from logging out or viewing their dashboard. Source: Known bug in bootstrap v3 and Safari - see twbs/bootstrap#14156 (for fix and link to underlying issue). Fixed by adding tabindex="0". NB: also checked in FF and FF seems fine though older FF may have an issue (FF also mentioned in the bootstrap issue).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14038 by using
<a tabindex="0">instead of<button>.Demo: http://jsfiddle.net/v5L7m/3/
Supporting research: https://gist.github.com/cvrebert/68659d0333a578d75372
Also moves the "Multiple-line links" callout together with the rest of the general Popover callouts.
Also switches from
{trigger: 'focus'}todata-trigger="focus".