Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Savage cross-browser JS pull request tester bot #15187

Merged
merged 1 commit into from
Nov 20, 2014

Conversation

cvrebert
Copy link
Collaborator

Refs https://github.com/twbs/savage & #12352.
CC: @twbs/team for review

@cvrebert cvrebert added this to the v3.3.2 milestone Nov 20, 2014
@cvrebert cvrebert added the docs label Nov 20, 2014
@juthilo juthilo mentioned this pull request Nov 20, 2014
@juthilo
Copy link
Collaborator

juthilo commented Nov 20, 2014

LGTM


[@twbs-rorschach](https://github.com/twbs-rorschach) is a Bootstrap bot that hangs out in our GitHub issue tracker and automatically checks all pull requests for a few simple common mistakes. It's possible that Rorschach might leave a comment on your pull request and then close it. If that happens, simply fix the problem(s) mentioned in the comment (there should be link(s) in the comment explaining the problem(s) in detail) and then either:

* Push the revised version to your pull request's branch and post a comment on the pull request saying that you've fixed the problem(s). One of the Bootstrap Core Team members will then come along and reopen your pull request.
* Or you can just open a new pull request for your revised version.

[@twbs-savage](https://github.com/twbs-savage) is a Bootstrap bot that automatically runs cross-browser tests (via [Sauce](https://saucelabs.com) and Travis CI) on JavaScript pull requests. Savage will leave a comment on JavaScript pull requests stating whether cross-browser tests passed or failed, with a link to the full Travis build details. If your pull request fails, check the Travis log to see which browser + OS combinations failed. Each browser test in the Travis log includes a link to a Sauce page with details about the test. On those details pages, you can watch a screencast of the test run to see exactly which unit tests failed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"JavaScript pull requests" seems redundant the second time.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Refs #12352, which is now implemented & deployed.
More info: https://github.com/twbs/savage

[skip sauce]
@cvrebert cvrebert force-pushed the doc-savage-contributing branch from a815e03 to 7711c9d Compare November 20, 2014 18:59
@hnrch02
Copy link
Collaborator

hnrch02 commented Nov 20, 2014

LGTM 👍

cvrebert added a commit that referenced this pull request Nov 20, 2014
Document Savage cross-browser JS pull request tester bot
[skip sauce]
@cvrebert cvrebert merged commit 7527ce9 into master Nov 20, 2014
@cvrebert cvrebert deleted the doc-savage-contributing branch November 20, 2014 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants