Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/merge advice on low percentage progress bars #15334

Merged
merged 1 commit into from
Dec 10, 2014
Merged

Fix/merge advice on low percentage progress bars #15334

merged 1 commit into from
Dec 10, 2014

Conversation

patrickhlauke
Copy link
Member

  • actually add the min-width extra style (and use em rather than
    px) to the 0% and 2% example
  • remove the unnecessarily redundant sentence in the "With labels"
    section
  • remove the unnecessary heading/section specifically for low percentage
    case, make it flow naturally as part of the "With labels" section

- actually add the ``min-width`` extra style (and use ``em`` rather than
``px``) to the 0% and 2% example
- remove the unnecessarily redundant sentence in the "With labels"
section
- remove the unnecessary heading/section specifically for low percentage
case, make it flow naturally as part of the "With labels" section
@cvrebert cvrebert added the docs label Dec 10, 2014
@mdo
Copy link
Member

mdo commented Dec 10, 2014

I can dig this. Awesome attention to detail btw.

@mdo mdo added this to the v3.3.2 milestone Dec 10, 2014
patrickhlauke added a commit that referenced this pull request Dec 10, 2014
Fix/merge advice on low percentage progress bars
@patrickhlauke patrickhlauke merged commit 69332cb into twbs:master Dec 10, 2014
@juthilo juthilo mentioned this pull request Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants