Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Firefox out of the Customizer due to file download heisenbug #15372

Closed
wants to merge 3 commits into from

Conversation

cvrebert
Copy link
Collaborator

Interim solution to #15016.
CC: @twbs/team for review

@cvrebert cvrebert added this to the v3.3.2 milestone Dec 15, 2014
@XhmikosR
Copy link
Member

I'm not in favor of this. The reason is that while many people seem to have this issue, others don't have it. Locking them out too is bad IMO.

Instead, we should warn only.

@mdo
Copy link
Member

mdo commented Dec 15, 2014

Disabling the customizer for everyone in Firefox sounds a bit harsh, but if y'all don't see a way around it, I'm not sure I do either.

@cvrebert
Copy link
Collaborator Author

@XhmikosR The bug seems to occur randomly; I've had the customizer succeed and fail at different times with the default variable values on the same computer. I guess it's a matter of how bad you consider "always fails" vs. "randomly fails"; a Firefox-specific warning is another option, yeah.

@XhmikosR
Copy link
Member

I know it's random; I'm a Firefox only user myself. But it's too harsh to do this especially being that we can't really follow if/when this is fixed.

On the other hand, come v4, this shouldn't matter, right?

@cvrebert
Copy link
Collaborator Author

On the other hand, come v4, this shouldn't matter, right?

Right.

@hnrch02
Copy link
Collaborator

hnrch02 commented Dec 16, 2014

I think a warning would suffice in this case. Simply pointing out that the builds can randomly fail in Firefox and that a different browser would be the better choice to build Bootstrap.

@cvrebert cvrebert closed this Dec 16, 2014
@cvrebert
Copy link
Collaborator Author

Will open a PR to add a warning callout instead.

@cvrebert cvrebert deleted the firefox-customizer branch December 16, 2014 04:13
@cvrebert cvrebert removed this from the v3.3.2 milestone Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants