From 995c7683307b2e39d8505989615967b5d7843caa Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 29 Dec 2014 11:57:56 -0800 Subject: [PATCH 1/3] bump grunt-jscs to ~1.1.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 91d807dea96f..771fd43244f3 100644 --- a/package.json +++ b/package.json @@ -53,7 +53,7 @@ "grunt-exec": "~0.4.6", "grunt-html-validation": "~0.1.18", "grunt-jekyll": "~0.4.2", - "grunt-jscs": "~1.0.0", + "grunt-jscs": "~1.1.0", "grunt-saucelabs": "~8.4.0", "grunt-sed": "~0.1.1", "load-grunt-tasks": "~2.0.0", From 9e66526766ca0d1ca639a53dd6e830efdb2d83c0 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 29 Dec 2014 12:00:47 -0800 Subject: [PATCH 2/3] update shrinkwrap --- test-infra/npm-shrinkwrap.json | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/test-infra/npm-shrinkwrap.json b/test-infra/npm-shrinkwrap.json index c0053f4be72c..855ccee2acda 100644 --- a/test-infra/npm-shrinkwrap.json +++ b/test-infra/npm-shrinkwrap.json @@ -3170,16 +3170,16 @@ } }, "grunt-jscs": { - "version": "1.0.0", - "resolved": "https://registry.npmjs.org/grunt-jscs/-/grunt-jscs-1.0.0.tgz", + "version": "1.1.0", + "resolved": "https://registry.npmjs.org/grunt-jscs/-/grunt-jscs-1.1.0.tgz", "dependencies": { "hooker": { "version": "0.2.3", "resolved": "https://registry.npmjs.org/hooker/-/hooker-0.2.3.tgz" }, "jscs": { - "version": "1.8.1", - "resolved": "https://registry.npmjs.org/jscs/-/jscs-1.8.1.tgz", + "version": "1.9.0", + "resolved": "https://registry.npmjs.org/jscs/-/jscs-1.9.0.tgz", "dependencies": { "colors": { "version": "1.0.3", @@ -3197,6 +3197,10 @@ "version": "1.1.0-dev-harmony", "resolved": "https://registry.npmjs.org/esprima-harmony-jscs/-/esprima-harmony-jscs-1.1.0-dev-harmony.tgz" }, + "estraverse": { + "version": "1.8.0", + "resolved": "https://registry.npmjs.org/estraverse/-/estraverse-1.8.0.tgz" + }, "exit": { "version": "0.1.2", "resolved": "https://registry.npmjs.org/exit/-/exit-0.1.2.tgz" @@ -3239,6 +3243,10 @@ } } }, + "regenerate": { + "version": "1.0.1", + "resolved": "https://registry.npmjs.org/regenerate/-/regenerate-1.0.1.tgz" + }, "strip-json-comments": { "version": "1.0.2", "resolved": "https://registry.npmjs.org/strip-json-comments/-/strip-json-comments-1.0.2.tgz" @@ -3247,6 +3255,10 @@ "version": "1.2.0", "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-1.2.0.tgz" }, + "unicode-6.3.0": { + "version": "0.1.5", + "resolved": "https://registry.npmjs.org/unicode-6.3.0/-/unicode-6.3.0-0.1.5.tgz" + }, "vow-fs": { "version": "0.3.4", "resolved": "https://registry.npmjs.org/vow-fs/-/vow-fs-0.3.4.tgz", From 2ae4c0b03f7fde62f99ea8324859fa60cd890163 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 29 Dec 2014 12:02:32 -0800 Subject: [PATCH 3/3] JSCS: enable requireSpaceBetweenArguments New rule added in JSCS v1.9.0 Our JS already complies with this. --- js/.jscsrc | 1 + 1 file changed, 1 insertion(+) diff --git a/js/.jscsrc b/js/.jscsrc index 9612c1683328..ac1d73f55e41 100644 --- a/js/.jscsrc +++ b/js/.jscsrc @@ -22,6 +22,7 @@ "requireSpaceAfterKeywords": ["if", "else", "for", "while", "do", "switch", "return", "try", "catch"], "requireSpaceAfterLineComment": true, "requireSpaceBeforeBinaryOperators": ["+", "-", "/", "*", "=", "==", "===", "!=", "!==", ">", "<", ">=", "<="], + "requireSpaceBetweenArguments": true, "requireSpacesInAnonymousFunctionExpression": { "beforeOpeningCurlyBrace": true, "beforeOpeningRoundBrace": true }, "requireSpacesInConditionalExpression": true, "requireSpacesInFunctionDeclaration": { "beforeOpeningCurlyBrace": true },