v4 - Move collapse js away from panels to cards

[kkirsche]

Fix #17170

Probably cc fat?

[cvrebert]

@kkirsche Could you please rebase this?

[kkirsche]

@cvrebert rebased

[kkirsche]

The failure here is unrelated to the change made:

Running "scsslint:src" (scsslint) task
Running scss-lint on src
scss/_reboot.scss:286 [W] PropertySortOrder: Properties should be ordered box-sizing, -webkit-appearance
Warning: Task "scsslint:src" failed.� Use --force to continue.
Aborted due to warnings.

[cvrebert]

@kkirsche × 4 tests failed in "collapse" module when I test it locally.
(There are some other failures, but those are also present in v4-dev 😒 )

[kkirsche]

@cvrebert noted. I'll look at those probably next week. Traveling for work this week so may be a bit before I can tackle making those fixes

[dalabarge]

Would it be possible to also have this be a configurable selector using data-selector or something? Having JS rely upon hard-coded HTML class names makes it more difficult to use semantic class names and then use SCSS to mixin the appropriate styles. Just spent an hour or so trying to get this working before reading the source and realizing it was selecting child elements of .panel (now .card) instead of just collapsing the elements matching $(parent).find('.collapse.in'). What's the reason we're sticking to making this plugin dependent upon any specific HTML class name?

[cvrebert]

@dalabarge That's still on the roadmap. This is just a quick fix until we can get around to implementing that.
See #17021:

Collapse

• Make accordion feature of collapse plugin independent of panels?: Collapsible parent option is dependent on dom structure #10966

[fat]

yeah this is great - do you mind just poppin ACTIVES selector onto the default object while you're at it so people can change?

[fat]

(otherwise lgtm)

[mdo]

Would love to get this merged into Alpha 5. Was @fat's feedback addressed?

[Johann-S]

My PR #18400 do the same things but is up to date and apply changes to js/tests/visual/modal.html which use Collapse too.

[mdo]

Merged #18400 to address this. Thanks though @kkirsche!

[kkirsche]

Course. Thanks for considering this