Linked card #25087
Closed
Linked card #25087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MartijnCuppens this is an intresting concept, and I think a full clickable card is a common use case. To be honest I don't like the class name |
scss/_card.scss
Outdated
| } | ||
|
|
||
| :not(.card) > & { | ||
| &::after{ |
There was a problem hiding this comment.
there is a space missing after the after
|
Thx for the review @andresgalante. The name of the class could indeed be improved. |
|
Nice work. How about cursor:pointer on the whole card? |
|
Closing this, #26184 covers this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18294:
.card-full-linkclass to links inside card. This adds a ::before pseudo-element to the link which is stretched over the card..card-full-linkclass. No styling is influenced by doing this.