From 72d622e5e8c5359150b5934a618a4e384a57d56d Mon Sep 17 00:00:00 2001 From: Martijn Cuppens Date: Tue, 4 Dec 2018 21:22:12 +0100 Subject: [PATCH 1/3] Stretched link --- scss/_utilities.scss | 1 + scss/utilities/_stretched-link.scss | 19 ++++ site/_data/nav.yml | 1 + site/docs/4.2/utilities/stretched-link.md | 100 ++++++++++++++++++++++ 4 files changed, 121 insertions(+) create mode 100644 scss/utilities/_stretched-link.scss create mode 100644 site/docs/4.2/utilities/stretched-link.md diff --git a/scss/_utilities.scss b/scss/_utilities.scss index 913fb852d58e..a5de31ba6a50 100644 --- a/scss/_utilities.scss +++ b/scss/_utilities.scss @@ -11,6 +11,7 @@ @import "utilities/screenreaders"; @import "utilities/shadows"; @import "utilities/sizing"; +@import "utilities/stretched-link"; @import "utilities/spacing"; @import "utilities/text"; @import "utilities/visibility"; diff --git a/scss/utilities/_stretched-link.scss b/scss/utilities/_stretched-link.scss new file mode 100644 index 000000000000..fb5066bf55dd --- /dev/null +++ b/scss/utilities/_stretched-link.scss @@ -0,0 +1,19 @@ +// +// Stretched link +// + +.stretched-link { + &::after { + position: absolute; + top: 0; + right: 0; + bottom: 0; + left: 0; + z-index: 1; + // Just in case `pointer-events: none` is set on a parent + pointer-events: auto; + content: ""; + // IE10 bugfix, see https://stackoverflow.com/questions/16947967/ie10-hover-pseudo-class-doesnt-work-without-background-color + background-color: rgba(0, 0, 0, 0); + } +} diff --git a/site/_data/nav.yml b/site/_data/nav.yml index 7b6ff7cd977e..3c101760742d 100644 --- a/site/_data/nav.yml +++ b/site/_data/nav.yml @@ -70,6 +70,7 @@ - title: Shadows - title: Sizing - title: Spacing + - title: Stretched link - title: Text - title: Vertical align - title: Visibility diff --git a/site/docs/4.2/utilities/stretched-link.md b/site/docs/4.2/utilities/stretched-link.md new file mode 100644 index 000000000000..53907ceee26d --- /dev/null +++ b/site/docs/4.2/utilities/stretched-link.md @@ -0,0 +1,100 @@ +--- +layout: docs +title: Stretched link +description: Easily make an element which contains a stretched link clickable. +group: utilities +--- + +Adding the `.stretched-link` class to a link will make the [containing block](https://developer.mozilla.org/en-US/docs/Web/CSS/Containing_block) of the `::after` pseudo element of the link clickable. In most cases, this means that an element with `position: relative;` which contains a link with the `.stretched-link` class is clickable. + +Cards are relative by default, so in this case you can safely add the `.stretched-link` class to a link in the card. + +{% capture example %} +
+ {% include icons/placeholder.svg width="100%" height="180" class="card-img-top" text=" " title="Card image cap" %} +
+
Card with stretched link
+

Some quick example text to build on the card title and make up the bulk of the card's content.

+ Go somewhere +
+
+{% endcapture %} +{% include example.html content=example %} + +Media objects are not relative by default, we need to add the `.position-relative` here to prevent the link from stretching outside the media object. + +{% capture example %} +
+ {% include icons/placeholder.svg width="144" height="144" class="mr-3" text=" " title="Generic placeholder image" %} +
+
Media with stretched link
+

Cras sit amet nibh libero, in gravida nulla. Nulla vel metus scelerisque ante sollicitudin. Cras purus odio, vestibulum in vulputate at, tempus viverra turpis. Fusce condimentum nunc ac nisi vulputate fringilla. Donec lacinia congue felis in faucibus.

+ Go somewhere +
+
+{% endcapture %} +{% include example.html content=example %} + +Columns are relative by default, so if we want to stretch the link over a row, we need to add the `.position-static` class to column and add the `.position-relative` to the row. + +{% capture example %} +
+
+ {% include icons/placeholder.svg width="100%" height="200" class="w-100" text=" " title="Generic placeholder image" %} +
+
+
Columns with stretched link
+

Cras sit amet nibh libero, in gravida nulla. Nulla vel metus scelerisque ante sollicitudin. Cras purus odio, vestibulum in vulputate at, tempus viverra turpis. Fusce condimentum nunc ac nisi vulputate fringilla. Donec lacinia congue felis in faucibus.

+ Go somewhere +
+
+{% endcapture %} +{% include example.html content=example %} + +Multiple links can be added to elements with a stretched link, but their `z-index` must be increased to be become clickable. + +{% capture example %} +
+ {% include icons/placeholder.svg width="100%" height="180" class="card-img-top" text=" " title="Card image cap" %} +
+
Card with multiple links
+

Some quick example text to build on the card title and make up the bulk of the card's content.

+

+ The whole card will be linked to this link +

+

+ This link will be unclickable, because the previous link is stretched over this link +

+

+ This link will be clickable because position: relative is added and the z-index is higher than the z-index of the ::after pseudo element of the stretched link +

+
+
+{% endcapture %} +{% include example.html content=example %} + +## Identifying the containing block + +If the stretched link doesn't seem to work, the [containing block](https://developer.mozilla.org/en-US/docs/Web/CSS/Containing_block#Identifying_the_containing_block) will probably be the cause. The following CSS properties will make an element the containing block: + +- A `position` value other than `static` +- A `transform` or `perspective` value other than `none` +- A `will-change` value of `transform` or `perspective` +- A `filter` value other than `none` or a `will-change` value of `filter` (only works on Firefox) + +{% capture example %} +
+ {% include icons/placeholder.svg width="100%" height="180" class="card-img-top" text=" " title="Card image cap" %} +
+
Card with stretched links
+

Some quick example text to build on the card title and make up the bulk of the card's content.

+

+ Stretched link will not work here, because position: relative is added to the link +

+

+ This stretched link will only be spread over the p-tag, because a transform is applied to it. +

+
+
+{% endcapture %} +{% include example.html content=example %} From 9e60ad571431fe97c130b0223c4759a004385317 Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Sat, 15 Dec 2018 21:14:05 +0200 Subject: [PATCH 2/3] Update site/docs/4.2/utilities/stretched-link.md Co-Authored-By: MartijnCuppens --- site/docs/4.2/utilities/stretched-link.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/site/docs/4.2/utilities/stretched-link.md b/site/docs/4.2/utilities/stretched-link.md index 53907ceee26d..c0c8940e10cb 100644 --- a/site/docs/4.2/utilities/stretched-link.md +++ b/site/docs/4.2/utilities/stretched-link.md @@ -1,13 +1,13 @@ --- layout: docs title: Stretched link -description: Easily make an element which contains a stretched link clickable. +description: Make any HTML element or Bootstrap component clickable by "stretching" a nested link via CSS. group: utilities --- -Adding the `.stretched-link` class to a link will make the [containing block](https://developer.mozilla.org/en-US/docs/Web/CSS/Containing_block) of the `::after` pseudo element of the link clickable. In most cases, this means that an element with `position: relative;` which contains a link with the `.stretched-link` class is clickable. +Add `.stretched-link` to a link to make it's [containing block](https://developer.mozilla.org/en-US/docs/Web/CSS/Containing_block) clickable via a `::after` pseudo element. In most cases, this means that an element with `position: relative;` that contains a link with the `.stretched-link` class is clickable. -Cards are relative by default, so in this case you can safely add the `.stretched-link` class to a link in the card. +Cards have `position: relative` by default in Bootstrap, so in this case you can safely add the `.stretched-link` class to a link in the card without any other HTML changes. {% capture example %}
@@ -21,7 +21,7 @@ Cards are relative by default, so in this case you can safely add the `.stretche {% endcapture %} {% include example.html content=example %} -Media objects are not relative by default, we need to add the `.position-relative` here to prevent the link from stretching outside the media object. +Media objects do not have `position: relative` by default, so we need to add the `.position-relative` here to prevent the link from stretching outside the media object. {% capture example %}
@@ -35,7 +35,7 @@ Media objects are not relative by default, we need to add the `.position-relativ {% endcapture %} {% include example.html content=example %} -Columns are relative by default, so if we want to stretch the link over a row, we need to add the `.position-static` class to column and add the `.position-relative` to the row. +Columns are `position: relative` by default, so clickable columns only require the `.stretched-link` class on a link. However, stretching a link over an entire `.row` requires `.position-static` on the column and `.position-relative` on the row. {% capture example %}
From bf7483d9f917114be05b2644de13de7f5c9ca1bd Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Fri, 21 Dec 2018 21:10:40 -0800 Subject: [PATCH 3/3] Add a notes about multiple links/targets, remove multiple link example --- site/docs/4.2/utilities/stretched-link.md | 24 ++--------------------- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/site/docs/4.2/utilities/stretched-link.md b/site/docs/4.2/utilities/stretched-link.md index c0c8940e10cb..5347307b53d7 100644 --- a/site/docs/4.2/utilities/stretched-link.md +++ b/site/docs/4.2/utilities/stretched-link.md @@ -9,6 +9,8 @@ Add `.stretched-link` to a link to make it's [containing block](https://develope Cards have `position: relative` by default in Bootstrap, so in this case you can safely add the `.stretched-link` class to a link in the card without any other HTML changes. +Multiple links and tap targets are not recommended with stretched links. However, some `position` and `z-index` styles can help should this be required. + {% capture example %}
{% include icons/placeholder.svg width="100%" height="180" class="card-img-top" text=" " title="Card image cap" %} @@ -51,28 +53,6 @@ Columns are `position: relative` by default, so clickable columns only require t {% endcapture %} {% include example.html content=example %} -Multiple links can be added to elements with a stretched link, but their `z-index` must be increased to be become clickable. - -{% capture example %} -
- {% include icons/placeholder.svg width="100%" height="180" class="card-img-top" text=" " title="Card image cap" %} -
-
Card with multiple links
-

Some quick example text to build on the card title and make up the bulk of the card's content.

-

- The whole card will be linked to this link -

-

- This link will be unclickable, because the previous link is stretched over this link -

-

- This link will be clickable because position: relative is added and the z-index is higher than the z-index of the ::after pseudo element of the stretched link -

-
-
-{% endcapture %} -{% include example.html content=example %} - ## Identifying the containing block If the stretched link doesn't seem to work, the [containing block](https://developer.mozilla.org/en-US/docs/Web/CSS/Containing_block#Identifying_the_containing_block) will probably be the cause. The following CSS properties will make an element the containing block: