Examples: Remove unnecessary id/aria-labelledby from cheatsheet accordions
#37718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit labelling (which then would also benefit from a `role="group"` or similar role) is only optional, and not really appropriate just for a cheatsheet https://www.w3.org/WAI/ARIA/apg/patterns/accordion/ Closes #37591
|
Thanks a lot for introducing this to Bootstrap ! Should I try to backport it to the documentation as well ? |
|
oh, balls, the docs actually do it. i missed it when doing a find/replace though, which is worrying. sorry, i'll get a PR to fix the docs themselves as well. EDIT: done #37766 |
patrickhlauke
added a commit
that referenced
this pull request
Dec 30, 2022
10 tasks
mdo
pushed a commit
that referenced
this pull request
Dec 31, 2022
XhmikosR
changed the title
id/aria-labelledby from cheatsheet accordionsid/aria-labelledby from cheatsheet accordions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explicit labelling (which then would also benefit from a
role="group"or similar role) is only optional, and not really appropriate just for a cheatsheethttps://www.w3.org/WAI/ARIA/apg/patterns/accordion/
Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #37591