Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placeholder shortcode color and background params when 'img' markup #38263

Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Mar 17, 2023

Description

In the placeholder shortcode, when the markup parameter is set to img:

  • Text color is fixed: fill='%23868e96'
  • Background color is fixed: fill='%23dee2e6'
    So the shortcode is not really dynamic in this case.

OK... it is only used for now in "Object fit" page with fixed colors. But still, I'm suggesting this change 😇

Motivation & Context

Make placeholder shortcode really react to dynamic text and background colors.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (N/A) My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review March 17, 2023 14:11
@mdo mdo merged commit f52d4a3 into main Mar 20, 2023
@mdo mdo deleted the main-jd-fix-placeholder-color-background-params-for-img-markup branch March 20, 2023 00:42
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants