Fix placeholder
shortcode color and background params when 'img' markup
#38263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
placeholder
shortcode, when the markup parameter is set toimg
:fill='%23868e96'
fill='%23dee2e6'
So the shortcode is not really dynamic in this case.
OK... it is only used for now in "Object fit" page with fixed colors. But still, I'm suggesting this change 😇
Motivation & Context
Make
placeholder
shortcode really react to dynamic text and background colors.Type of changes
Checklist
npm run lint
)Live previews