change-version.js: handle rubygems specific version number #38452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
changed the title
change-version.js
XhmikosR
reviewed
Apr 12, 2023
|
Yeah, unfortunately, this doesn't work in the sense that it will still produce the wrong version for rubygems. I fixed it, but I'm not sure I like the |
XhmikosR
changed the title
change-version.jschange-version.js: handle rubygems specific version number
XhmikosR
changed the title
change-version.js: handle rubygems specific version number
XhmikosR
approved these changes
Apr 12, 2023
XhmikosR
deleted the
main-jd-handle-ruby-versioning-in-change-version-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In fe0c743, we are changing the
current_ruby_versionvalue to"5.3.0.alpha3".When we will run
npm run release-version 5.3.0-alpha3 5.3.0,config.ymlwon't be modified forcurrent_ruby_versionbecause it won't match5.3.0-alpha3.This PR is a very naive approach to handling this specific use case.
It is probably more a ping for you @XhmikosR than a real solution.
Feel free to change it or close it if not necessary.