Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes are not found when package is consumed by Cake.Frosting project #46

Open
mgnslndh opened this issue Sep 30, 2021 · 1 comment
Open

Comments

@mgnslndh
Copy link
Contributor

Problem

When the package is consumed by a Cake.Frosting project the Cake.MarkdownToPdf.dll is copied to the project's bin target directory. When the theme path is resolved it will use the assembly's location as the base directory but it will not find any themes because they are still in the user's NuGet cache.

Proposition

I can think of at least two ways of solving this. Not sure which one is best or if there is a better way of doing this.

  1. Use either NuGet conventions or a .targets file to make sure that the themes are copied to the same location as the assembly.
  2. Change the theme resolution to also look in the user's NuGet cache

Would you consider a PR fixing this?

@mgnslndh
Copy link
Contributor Author

mgnslndh commented Oct 1, 2021

I guess option 2 is not that good since it would only work when you build and run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant