-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize for packagist production #3503
Comments
excluding the doc source code from the archive indeed probably makes sense (that's probably the bulk of these 640KB as others are small files) |
Yes it's now 620KB |
Here is a list of the useless files: https://github.com/code-lts/doctum/blob/b2fca74060ba1a84c1dac23eec21221fbc589524/releases/5.4.0-dev/manifest.json#L3712 Files: "vendor/twig/twig/.gitignore",
"vendor/twig/twig/CHANGELOG",
"vendor/twig/twig/composer.json",
"vendor/twig/twig/README.rst",
"vendor/twig/twig/.gitattributes",
"vendor/twig/twig/drupal_test.sh",
"vendor/twig/twig/.php_cs.dist",
"vendor/twig/twig/.editorconfig", Folders: "vendor/twig/twig/doc",
"vendor/twig/twig/.github", |
Most files mentioned above do not contribute significantly to the size of the archive. Can some create a PR to exclude the doc/ directory as this is indeed contributing significantly? |
Multiply it by the number of installs of twig ;) |
@williamdes But these aren't installed in one system. |
When downloading the Twig package from packagist a lot of files are included which are never used in production or even by the developer itself. Have a look, this is what I get in my
vendor/twig/twig
folder aftercomposer require "twig/twig:^3.0"
:Files and directories I think can be ignored:
These files together are 640kb, while the whole package is about 1700kb. That's about 48% of the total file size.
Please fix this. Love the package, thank you <3
The text was updated successfully, but these errors were encountered: