-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helix: Add missing documentation for endpoints #11
Comments
Hi! I'd love to help out with this, if you'll have me. |
Hi @GreatGhostsss, we would be happy about help with this. The methods are all defined in https://github.com/twitch4j/twitch4j/blob/master/rest-helix/src/main/java/com/github/twitch4j/helix/TwitchHelix.java. Those docs for those endpoints will appear under https://twitch4j.github.io/docs/rest-helix/ once added. We have a docs contribution page - https://twitch4j.github.io/docs/contribution/documentation/ - which is very technical about markdown currently. If you have any questions or need any information to get started feel free to ask them in here or hop into the discord chat at https://discord.gg/FQ5vgW3. We can also use that as feedback to improve our contribution page :) There is no one else working on this right now, so you could pick one method of your choice to get started. |
Hi, I would like to work on this task. |
@EleekaN thanks for your willingness to help! Sorry about the link mixup, we had a docs overhaul & haven't updated all links. Regardless, the correct directory is: https://github.com/twitch4j/twitch4j.github.io/tree/master/docs/versioned_docs/version-1.x/rest-helix To write these docs, it is very useful to crossreference twitch's official docs and/or twitch4j's javadocs Also, feel free to join our Discord for more assistance |
Thank you @iProdigy for your quick response. Let me go through the details. I will connect with you again. Will try out Discord too, for any help. |
How can I get the code snippets? Is there a different tool I should use? |
The method definitions can be found here: https://github.com/twitch4j/twitch4j/blob/master/rest-helix/src/main/java/com/github/twitch4j/helix/TwitchHelix.java The example usage is new code that must be written. If you're not comfortable with writing the example snippets, I can provide some in the discord if you share which endpoint you're documenting. |
I picked the one next in the list "GetDropsEntitlement", I haven't started documenting yet, however trying to figure out the requirements. |
@EleekaN I've updated the list of methods that need documentation & improved the rough order of priority. Feel free to continue with For further code examples, just ask in the discord (& we can also assist in translating the java to kotlin or groovy)! |
Thank you so much. I will update you soon. |
Hi @iProdigy, greetings for the new year! |
@EleekaN To write the code snippets, I'd install an IDE like IntelliJ (you can clone the twitch4j project or import the library via maven or gradle) to help out with code completion & error checking (assuming you already know Java) Another aid is looking at existing usages... for example: https://github.com/twitch4j/twitch4j/blob/9605003e6ccbc8606ed758a58d6f110d5d1a2807/rest-helix/src/test/java/com/github/twitch4j/helix/endpoints/ChannelServiceTest.java#L33 (also sometimes we have snippets already posted in the discord - try a search) |
Description
These endpoints lack markdown documentation
Solutions
Add markdown docs
Additional context
Official helix documentation: https://dev.twitch.tv/docs/api/reference
Directory for markdown docs: https://github.com/twitch4j/twitch4j.github.io/tree/master/docs/versioned_docs/version-1.x/rest-helix
Method definitions: https://github.com/twitch4j/twitch4j/blob/master/rest-helix/src/main/java/com/github/twitch4j/helix/TwitchHelix.java
Javadoc: https://twitch4j.github.io/javadoc/com/github/twitch4j/helix/TwitchHelix.html
The text was updated successfully, but these errors were encountered: