make device_class an enum

[jacobrosenthal]

We can provide comments then so people know they want the HID one for mice, keyboards joystics etc vs googling

[twitchyliquid64]

Sorry, I don't quite understand. What did you have in mind?

[jacobrosenthal]

    unsafe {
        USB_HID = Some(HIDClass::new(&bus_allocator, MouseReport::desc(), 60));
        USB_BUS = Some(
            UsbDeviceBuilder::new(&bus_allocator, UsbVidPid(0x16c0, 0x27dd))
                .manufacturer("Fake company")
                .product("Twitchy Mousey")
                .serial_number("TEST")
                .device_class(0xEF) // <- MISC instead of 0xEF
                .build(),
        );
    }

[twitchyliquid64]

Ah, the device class in the USB Device descriptor.

I'm happy to add an enum for HID specific values, but shouldnt more generic ones like MISC be exposed in something like the usb-device crate?

[brainstorm]

Yes but those that are HIDs like mouse, joystick and keyboard should be in this crate, right? Thanks for this crate! :)

[twitchyliquid64]

Yeppers, I think it would be nice to have the really common descriptors ready to go in this crate (keyboard/mouse/joystick/etc). But i dont think we should try and be exhaustive.

From memory we already have a keyboard one (and maybe a mouse?), but feel free to send PRs for anything major missing.