Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kibisis): lower get provider timeout from 3 seconds to 0.75 seconds #133

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix(kibisis): lower get provider timeout from 3 seconds to 0.75 seconds #133

merged 1 commit into from
Jan 30, 2024

Conversation

kieranroneill
Copy link
Contributor

@kieranroneill kieranroneill commented Jan 30, 2024

Description

Please explain the changes you made here

Currently, when initializing the Kibisis client, a message is broadcast for discovery of the Kibisis that has a 3 second timeout. However, as the response should be quicker than this, the timeout is unnecessary long which blocks the initialization of other clients.

A 0.75 second timer provides a better compromise.

Checklist

Please, make sure to comply with the checklist below before expecting review

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@drichar drichar merged commit fadf667 into TxnLab:main Jan 30, 2024
1 check passed
@kieranroneill kieranroneill deleted the fix/kibisis/shorten-provide-inituialization-delay branch February 6, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants