New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): use correct `this` context in setActiveNetwork #163

Merged

drichar merged 1 commit into v3 from fix/set-active-network-this

Apr 11, 2024

Collaborator

drichar commented Apr 11, 2024 •

edited

Loading

The WalletManager's setActiveNetwork method was missed when I was changing wallet client methods to arrow functions in #152

This (ha!) update ensures the correct this context is used when setActiveNetwork is passed as a callback to the framework adapters.

Closes #158


          fix(core): use correct this context in setActiveNetwork

253158a

drichar force-pushed the fix/set-active-network-this branch from e0ea8c1 to 253158a Compare

April 11, 2024 06:28

drichar merged commit b48dd33 into v3

1 check passed

drichar deleted the fix/set-active-network-this branch

April 11, 2024 06:30

drichar added the v3 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3