fix Kibisis init in vue app #203 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i faced the same issue as in TxnLab#203 the issue is that the import in vuejs has the default, so fixed it the same way as it is done in defly f.e.
|
Looking good to me 👍 So this relates to AVM Web Provider using the old style CommonJS and UseWallet using ESM? |
|
Thanks for this fix! Please run the linting/formatting scripts in the root of the repository and fix any reported errors. I'll need to add a CONTRIBUTING.md file with guidelines and instructions. |
|
i have just updated the code in github web, feel free to run the linting after you merge it or setup some pipeline to do so automatically |
drichar
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i faced the same issue as in #203 the issue is that the import in vuejs has the default, so fixed it the same way as it is done in defly f.e.